Skip to content
This repository was archived by the owner on Apr 1, 2020. It is now read-only.

Conversation

@caarlos0
Copy link
Contributor

@caarlos0 caarlos0 commented Oct 3, 2019

refs #7

Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
@caarlos0
Copy link
Contributor Author

caarlos0 commented Oct 3, 2019

gently cc/ @z0al :D

@caarlos0
Copy link
Contributor Author

caarlos0 commented Oct 3, 2019

it will look like this:

image

@z0al
Copy link
Owner

z0al commented Oct 4, 2019

Hey @caarlos0, great work ✨ , thanks.

I haven't been able to touch this repo in a while, I will review this ASAP

P.S. I'm a big fan of your OSS work, keep it up.

@caarlos0
Copy link
Contributor Author

caarlos0 commented Oct 4, 2019

Thanks @z0al :D

I'm not used to write js and stuff, let me know if I did something wrong or not in the best way :)

I did run the tests and deployed it to heroku - and both worked, so... there is that at least haha

Cheers

@z0al
Copy link
Owner

z0al commented Oct 11, 2019

Merged 413a39b

I'm not used to write js and stuff, let me know if I did something wrong or not in the best way :)

Hahah, I wrote this 2 years ago while learning JS so my code isn't perfect either :D

Note: Please keep in mind that these changes won't show up yet since I'm currently having a fight to deploy this to Now 2.0 and probably need to upgrade the code to a recent Probot version.

Thank you.

@z0al z0al closed this Oct 11, 2019
@caarlos0 caarlos0 deleted the msgs branch October 11, 2019 17:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants